Issue 33050 claude workflow security #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create reusable org-membership-check action to verify dotCMS membership - Update Claude workflow with security gate that blocks non-members - Hardcode organization to prevent override attacks - Add comprehensive logging for security decisions Addresses security concern from issue dotCMS#33050 where external users could trigger Claude workflows by mentioning @claude in comments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The GitHub API returns different responses for private vs public membership: - Public members: Returns user object - Private members: Returns empty response with 200 OK - Non-members: Returns 404 error Previous logic only checked exit codes and failed to detect private members like organization owners who have private visibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add detailed comments explaining GitHub's membership API behavior: - HTTP 200 = member (regardless of response content) - HTTP 404 = non-member - Private members return empty response but still 200 OK - Public members return user object with 200 OK This design decision ensures all org members are authorized correctly without needing to parse different response formats. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots